1.3 Development

Hi,

I found an error message when adding a static IP assignment to the DHCP server configuration slightly confusing.

The error message was "Static IP addresses may not lie within the dynamic client range", and I know it sounds dumb but I assumed that the static addresses should lie within the range that the DHCP server is assigning. So I thought that it meant that m0n0wall was not sure if the address lay inside the dynamic range - hence the "may not lie within" message.

To remove any ambiguity it might be helpful to change the message to "Static IP addresses must not lie within the dynamic client range", to help people like myself.

I'm actually using V1.232 right now, and the change should equally apply there, but here is a patch for the one word change against the SVN trunk in case it helps to clarify:

Code:

Index: services_dhcp_edit.php
===================================================================
--- services_dhcp_edit.php (revision 226)
+++ services_dhcp_edit.php (working copy)
@@ -100,7 +100,7 @@
 
  if ((ip2long($_POST['ipaddr']) >= $dynsubnet_start) &&
  (ip2long($_POST['ipaddr']) <= $dynsubnet_end)) {
- $input_errors[] = "Static IP addresses may not lie within the dynamic client range.";
+ $input_errors[] = "Static IP addresses must not lie within the dynamic client range.";
  }
  if ((ip2long($_POST['ipaddr']) < $lansubnet_start) ||
  (ip2long($_POST['ipaddr']) > $lansubnet_end)) {

Hope that helps - thanks for the great work on m0n0wall.

Andrew